Changeset 15376 in webkit for trunk/JavaScriptCore/API/JSCallbackFunction.h

Timestamp:

Jul 12, 2006, 1:12:08 AM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Implemented a vast number of renames and comment clarifications suggested during API review.

JSInternalString -> JSString
JS*Make -> JSValueMake*, JSObjectMake*
JSTypeCode -> JSType
JSValueIsInstanceOf -> JSValueIsInstanceOfConstructor (reads strangely well in client code)
JSGC*Protect -> JSValue*Protect
JS*Callback -> JSObject*Callback
JSGetPropertyListCallback -> JSObjectAddPropertiesToListCallback
JSPropertyEnumeratorGetNext -> JSPropertyEnumeratorGetNextName
JSString* ->

JSStringCreateWithUTF8CString, JSStringGetUTF8CString,
JSStringGetMaximumUTF8CStringSize JSStringIsEqualToUTF8CString,
JSStringCreateWithCFString, JSStringCopyCFString, JSStringCreateWithCharacters.

• Changed functions taking a JSValue out arg and returning a bool indicating whether it was set to simply return a JSValue or NULL.

• Removed JSStringGetCharacters because it's more documentation than code, and it's just a glorified memcpy built on existing API functionality.

• Moved standard library includes into the headers that actually require them.

• Standardized use of the phrase "Create Rule."

• Removed JSLock from make functions that don't allocate.

• Added exception handling to JSValueToBoolean, since we now allow callback objects to throw exceptions upon converting to boolean.

• Renamed JSGCCollect to JSGarbageCollect.

File:

• trunk/JavaScriptCore/API/JSCallbackFunction.h (modified) (2 diffs)

trunk/JavaScriptCore/API/JSCallbackFunction.h

@@ -37 +37 @@
 {
 public:
-    JSCallbackFunction(ExecState* exec, JSCallAsFunctionCallback callback);
+    JSCallbackFunction(ExecState* exec, JSObjectCallAsFunctionCallback callback);
 
     virtual bool implementsCall() const;
@@ -53 +53 @@
     
     void* m_privateData;
-    JSCallAsFunctionCallback m_callback;
+    JSObjectCallAsFunctionCallback m_callback;
 };