Changeset 15376 in webkit for trunk/JavaScriptCore/API/JSContextRef.cpp

Timestamp:

Jul 12, 2006, 1:12:08 AM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Implemented a vast number of renames and comment clarifications suggested during API review.

JSInternalString -> JSString
JS*Make -> JSValueMake*, JSObjectMake*
JSTypeCode -> JSType
JSValueIsInstanceOf -> JSValueIsInstanceOfConstructor (reads strangely well in client code)
JSGC*Protect -> JSValue*Protect
JS*Callback -> JSObject*Callback
JSGetPropertyListCallback -> JSObjectAddPropertiesToListCallback
JSPropertyEnumeratorGetNext -> JSPropertyEnumeratorGetNextName
JSString* ->

JSStringCreateWithUTF8CString, JSStringGetUTF8CString,
JSStringGetMaximumUTF8CStringSize JSStringIsEqualToUTF8CString,
JSStringCreateWithCFString, JSStringCopyCFString, JSStringCreateWithCharacters.

• Changed functions taking a JSValue out arg and returning a bool indicating whether it was set to simply return a JSValue or NULL.

• Removed JSStringGetCharacters because it's more documentation than code, and it's just a glorified memcpy built on existing API functionality.

• Moved standard library includes into the headers that actually require them.

• Standardized use of the phrase "Create Rule."

• Removed JSLock from make functions that don't allocate.

• Added exception handling to JSValueToBoolean, since we now allow callback objects to throw exceptions upon converting to boolean.

• Renamed JSGCCollect to JSGarbageCollect.

File:

• trunk/JavaScriptCore/API/JSContextRef.cpp (modified) (2 diffs)

trunk/JavaScriptCore/API/JSContextRef.cpp

@@ -63 +63 @@
 }
 
-JSValueRef JSEvaluate(JSContextRef context, JSInternalStringRef script, JSObjectRef thisObject, JSInternalStringRef sourceURL, int startingLineNumber, JSValueRef* exception)
+JSValueRef JSEvaluate(JSContextRef context, JSStringRef script, JSObjectRef thisObject, JSStringRef sourceURL, int startingLineNumber, JSValueRef* exception)
 {
     JSLock lock;
@@ -86 +86 @@
 }
 
-bool JSCheckSyntax(JSContextRef context, JSInternalStringRef script, JSInternalStringRef sourceURL, int startingLineNumber, JSValueRef* exception)
+bool JSCheckSyntax(JSContextRef context, JSStringRef script, JSStringRef sourceURL, int startingLineNumber, JSValueRef* exception)
 {
     JSLock lock;