Ignore:
Timestamp:
Jul 12, 2006, 1:12:08 AM (19 years ago)
Author:
ggaren
Message:

Reviewed by Maciej.


  • Implemented a vast number of renames and comment clarifications suggested during API review.


JSInternalString -> JSString
JS*Make -> JSValueMake*, JSObjectMake*
JSTypeCode -> JSType
JSValueIsInstanceOf -> JSValueIsInstanceOfConstructor (reads strangely well in client code)
JSGC*Protect -> JSValue*Protect
JS*Callback -> JSObject*Callback
JSGetPropertyListCallback -> JSObjectAddPropertiesToListCallback
JSPropertyEnumeratorGetNext -> JSPropertyEnumeratorGetNextName
JSString* ->

JSStringCreateWithUTF8CString, JSStringGetUTF8CString,
JSStringGetMaximumUTF8CStringSize JSStringIsEqualToUTF8CString,
JSStringCreateWithCFString, JSStringCopyCFString, JSStringCreateWithCharacters.


  • Changed functions taking a JSValue out arg and returning a bool indicating whether it was set to simply return a JSValue or NULL.


  • Removed JSStringGetCharacters because it's more documentation than code, and it's just a glorified memcpy built on existing API functionality.


  • Moved standard library includes into the headers that actually require them.


  • Standardized use of the phrase "Create Rule."


  • Removed JSLock from make functions that don't allocate.


  • Added exception handling to JSValueToBoolean, since we now allow callback objects to throw exceptions upon converting to boolean.


  • Renamed JSGCCollect to JSGarbageCollect.
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/JavaScriptCore.exp

    r15321 r15376  
    22.objc_class_name_WebScriptObjectPrivate
    33.objc_class_name_WebUndefined
    4 _CFStringCreateWithJSInternalString
    5 _JSBooleanMake
    64_JSCheckSyntax
    75_JSClassCreate
    86_JSClassRelease
    97_JSClassRetain
    10 _JSConstructorMake
    118_JSContextCreate
    129_JSContextDestroy
    1310_JSContextGetGlobalObject
    1411_JSEvaluate
    15 _JSFunctionMake
    16 _JSFunctionMakeWithBody
    17 _JSGCCollect
    18 _JSGCProtect
    19 _JSGCUnprotect
    20 _JSInternalStringCreate
    21 _JSInternalStringCreateCF
    22 _JSInternalStringCreateUTF8
    23 _JSInternalStringGetCharacters
    24 _JSInternalStringGetCharactersPtr
    25 _JSInternalStringGetCharactersUTF8
    26 _JSInternalStringGetLength
    27 _JSInternalStringGetMaxLengthUTF8
    28 _JSInternalStringIsEqual
    29 _JSInternalStringIsEqualUTF8
    30 _JSInternalStringRelease
    31 _JSInternalStringRetain
    32 _JSNullMake
    33 _JSNumberMake
     12_JSGarbageCollect
    3413_JSObjectCallAsConstructor
    3514_JSObjectCallAsFunction
    … …  
    4423_JSObjectIsFunction
    4524_JSObjectMake
     25_JSObjectMakeConstructor
     26_JSObjectMakeFunction
     27_JSObjectMakeFunctionWithBody
    4628_JSObjectSetPrivate
    4729_JSObjectSetProperty
    4830_JSObjectSetPrototype
    49 _JSPropertyEnumeratorGetNext
     31_JSPropertyEnumeratorGetNextName
    5032_JSPropertyEnumeratorRelease
    5133_JSPropertyEnumeratorRetain
    5234_JSPropertyListAdd
    53 _JSStringMake
    54 _JSUndefinedMake
    55 _JSValueCopyStringValue
     35_JSStringCopyCFString
     36_JSStringCreateWithCFString
     37_JSStringCreateWithCharacters
     38_JSStringCreateWithUTF8CString
     39_JSStringGetCharactersPtr
     40_JSStringGetLength
     41_JSStringGetMaximumUTF8CStringSize
     42_JSStringGetUTF8CString
     43_JSStringIsEqual
     44_JSStringIsEqualToUTF8CString
     45_JSStringRelease
     46_JSStringRetain
    5647_JSValueGetType
    5748_JSValueIsBoolean
    5849_JSValueIsEqual
    59 _JSValueIsInstanceOf
     50_JSValueIsInstanceOfConstructor
    6051_JSValueIsNull
    6152_JSValueIsNumber
    … …  
    6556_JSValueIsString
    6657_JSValueIsUndefined
     58_JSValueMakeBoolean
     59_JSValueMakeNull
     60_JSValueMakeNumber
     61_JSValueMakeString
     62_JSValueMakeUndefined
     63_JSValueProtect
    6764_JSValueToBoolean
    6865_JSValueToNumber
    6966_JSValueToObject
     67_JSValueToStringCopy
     68_JSValueUnprotect
    7069_KJS_JSCreateNativeJSObject
    7170_KJS_JSObject_JSFinalize
Note: See TracChangeset for help on using the changeset viewer.