Changeset 153825 in webkit for trunk/Source/JavaScriptCore/interpreter/Interpreter.h

Timestamp:

Aug 8, 2013, 9:57:07 AM (12 years ago)

Author:

[email protected]

Message:

Restoring use of StackIterator instead of Interpreter::getStacktrace().
​https://bugs.webkit.org/show_bug.cgi?id=119575.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

• interpreter/Interpreter.h:
• Made getStackTrace() private.
• interpreter/StackIterator.cpp:

(JSC::StackIterator::StackIterator):
(JSC::StackIterator::numberOfFrames):

• Computes the number of frames by iterating through the whole stack from the starting frame. The iterator will save its current frame position before counting the frames, and then restoring it after the counting.

(JSC::StackIterator::gotoFrameAtIndex):
(JSC::StackIterator::gotoNextFrame):
(JSC::StackIterator::resetIterator):

• Points the iterator to the starting frame.
• interpreter/StackIteratorPrivate.h:

Source/WebCore:

No new tests.

• bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

File:

• trunk/Source/JavaScriptCore/interpreter/Interpreter.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/interpreter/Interpreter.h

@@ -234 +234 @@
         JS_EXPORT_PRIVATE void dumpCallFrame(CallFrame*);
 
-        JS_EXPORT_PRIVATE void getStackTrace(Vector<StackFrame>& results, size_t maxStackSize = std::numeric_limits<size_t>::max());
-
     private:
         enum ExecutionFlag { Normal, InitializeAndReturn };
@@ -243 +241 @@
         JSValue execute(CallFrameClosure&);
 
+        void getStackTrace(Vector<StackFrame>& results, size_t maxStackSize = std::numeric_limits<size_t>::max());
         NEVER_INLINE bool unwindCallFrame(StackIterator&, JSValue);