Changeset 15385 in webkit for trunk/JavaScriptCore/API/JSObjectRef.h

Timestamp:

Jul 12, 2006, 3:01:06 AM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Removed context and exception parameters from JSObjectGetPropertyEnumerator, removing the spurious use of ExecState inside JavaScriptCore that made us think this was necessary in the first place.

(StringInstance::getPropertyList): Use getString instead of toString because
we know we're dealing with a string -- we put it there in the first place.
While we're at it, store the string's size instead of retrieving it each time
through the loop, to avoid the unnecessary killing of puppies.

• kjs/string_object.h:

File:

• trunk/JavaScriptCore/API/JSObjectRef.h (modified) (4 diffs)

trunk/JavaScriptCore/API/JSObjectRef.h

@@ -156 +156 @@
 @typedef JSObjectAddPropertiesToListCallback
 @abstract The callback invoked when adding an object's properties to a property list.
-@param context The current execution context.
 @param object The JSObject whose properties need to be added to propertyList.
 @param propertyList A JavaScript property list that will be used to enumerate object's properties.
-@param exception A pointer to a JSValueRef in which to return an exception, if any.
 @discussion If you named your function GetPropertyList, you would declare it like this:
 
-void AddPropertiesToList(JSContextRef context, JSObjectRef object, JSPropertyListRef propertyList, JSValueRef* exception);
+void AddPropertiesToList(JSObjectRef object, JSPropertyListRef propertyList);
 
 Use JSPropertyListAdd to add properties to propertyList.
@@ -169 +167 @@
 */
 typedef void
-(*JSObjectAddPropertiesToListCallback) (JSContextRef context, JSObjectRef object, JSPropertyListRef propertyList, JSValueRef* exception);
+(*JSObjectAddPropertiesToListCallback) (JSObjectRef object, JSPropertyListRef propertyList);
 
 /*! 
@@ -261 +259 @@
 @field setProperty The callback invoked when setting the value of a given property.
 @field deleteProperty The callback invoked when deleting a given property.
-@field getPropertyList The callback invoked when adding an object's properties to a property list.
+@field addPropertiesToList The callback invoked when adding an object's properties to a property list.
 @field callAsFunction The callback invoked when an object is called as a function.
 @field hasInstance The callback invoked when an object is used in an 'instanceof' expression.
@@ -507 +505 @@
 @function
 @abstract Creates an enumerator for an object's properties.
-@param context The execution context to use.
 @param object The object whose properties you want to enumerate.
 @result A JSPropertyEnumerator with a list of object's properties. Ownership follows the Create Rule.
 */
-JSPropertyEnumeratorRef JSObjectCreatePropertyEnumerator(JSContextRef context, JSObjectRef object);
+JSPropertyEnumeratorRef JSObjectCreatePropertyEnumerator(JSObjectRef object);
 /*!
 @function