Changeset 154199 in webkit for trunk/Source/JavaScriptCore/jit/JITStubs.cpp

Timestamp:

Aug 16, 2013, 12:15:31 PM (12 years ago)

Author:

[email protected]

Message:

Object properties added using dot syntax (o.f = ...) from code that isn't in eval should be less likely to cause an object to become a dictionary
​https://bugs.webkit.org/show_bug.cgi?id=119897

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

6-10x speed-up on microbenchmarks that create large static objects. 40-65% speed-up
on Octane/gbemu. 3% overall speed-up on Octane. No slow-downs anywhere; our ability
to turn objects into dictionaries when you're storing using bracket syntax or using
eval is still in place.

• bytecode/CodeBlock.h:

(JSC::CodeBlock::putByIdContext):

• dfg/DFGOperations.cpp:
• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• runtime/JSObject.h:

(JSC::JSObject::putDirectInternal):

• runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::PutPropertySlot):
(JSC::PutPropertySlot::context):

• runtime/Structure.cpp:

(JSC::Structure::addPropertyTransition):

• runtime/Structure.h:

LayoutTests:

Reviewed by Oliver Hunt.

• fast/js/regress/lots-of-fields-expected.txt: Added.
• fast/js/regress/lots-of-fields.html: Added.
• fast/js/regress/script-tests/lots-of-fields.js: Added.

(foo):

File:

• trunk/Source/JavaScriptCore/jit/JITStubs.cpp (modified) (6 diffs)

trunk/Source/JavaScriptCore/jit/JITStubs.cpp

@@ -476 +476 @@
     STUB_INIT_STACK_FRAME(stackFrame);
 
-    PutPropertySlot slot(stackFrame.callFrame->codeBlock()->isStrictMode());
+    PutPropertySlot slot(
+        stackFrame.callFrame->codeBlock()->isStrictMode(),
+        stackFrame.callFrame->codeBlock()->putByIdContext());
     stackFrame.args[0].jsValue().put(stackFrame.callFrame, stackFrame.args[1].identifier(), stackFrame.args[2].jsValue(), slot);
     CHECK_FOR_EXCEPTION_AT_END();
@@ -485 +487 @@
     STUB_INIT_STACK_FRAME(stackFrame);
     
-    PutPropertySlot slot(stackFrame.callFrame->codeBlock()->isStrictMode());
+    PutPropertySlot slot(
+        stackFrame.callFrame->codeBlock()->isStrictMode(),
+        stackFrame.callFrame->codeBlock()->putByIdContext());
     JSValue baseValue = stackFrame.args[0].jsValue();
     ASSERT(baseValue.isObject());
@@ -517 +521 @@
     AccessType accessType = static_cast<AccessType>(stubInfo->accessType);
 
-    PutPropertySlot slot(callFrame->codeBlock()->isStrictMode());
+    PutPropertySlot slot(
+        callFrame->codeBlock()->isStrictMode(),
+        callFrame->codeBlock()->putByIdContext());
     stackFrame.args[0].jsValue().put(callFrame, ident, stackFrame.args[2].jsValue(), slot);
     
@@ -538 +544 @@
     AccessType accessType = static_cast<AccessType>(stubInfo->accessType);
 
-    PutPropertySlot slot(callFrame->codeBlock()->isStrictMode());
+    PutPropertySlot slot(
+        callFrame->codeBlock()->isStrictMode(),
+        callFrame->codeBlock()->putByIdContext());
     JSValue baseValue = stackFrame.args[0].jsValue();
     ASSERT(baseValue.isObject());
@@ -559 +567 @@
     Identifier& ident = stackFrame.args[1].identifier();
     
-    PutPropertySlot slot(callFrame->codeBlock()->isStrictMode());
+    PutPropertySlot slot(
+        callFrame->codeBlock()->isStrictMode(),
+        callFrame->codeBlock()->putByIdContext());
     stackFrame.args[0].jsValue().put(callFrame, ident, stackFrame.args[2].jsValue(), slot);
 
@@ -572 +582 @@
     Identifier& ident = stackFrame.args[1].identifier();
     
-    PutPropertySlot slot(callFrame->codeBlock()->isStrictMode());
+    PutPropertySlot slot(
+        callFrame->codeBlock()->isStrictMode(),
+        callFrame->codeBlock()->putByIdContext());
     JSValue baseValue = stackFrame.args[0].jsValue();
     ASSERT(baseValue.isObject());