Changeset 15443 in webkit for trunk/JavaScriptCore/API/minidom.c

Timestamp:

Jul 14, 2006, 9:10:31 PM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Finalized exception handling in the API.

setProperty can throw because it throws for built-in arrays. getProperty
and deleteProperty can throw because setProperty can throw and we want
to be consistent, and also because they seem like "actions." callAsFunction,
callAsConstructor, and hasInstance can throw, because they caan throw for
all built-ins.

toBoolean can't throw because it's defined that way in the spec.

• Documented that toBoolean and toObject can't be overridden by custom objects because they're defined that way in the spec.

File:

• trunk/JavaScriptCore/API/minidom.c (modified) (1 diff)

trunk/JavaScriptCore/API/minidom.c

@@ -41 +41 @@
     
     JSStringRef printIString = JSStringCreateWithUTF8CString("print");
-    JSObjectSetProperty(context, globalObject, printIString, JSObjectMakeFunction(context, print), kJSPropertyAttributeNone);
+    JSObjectSetProperty(context, globalObject, printIString, JSObjectMakeFunction(context, print), kJSPropertyAttributeNone, NULL);
     JSStringRelease(printIString);
     
     JSStringRef node = JSStringCreateWithUTF8CString("Node");
-    JSObjectSetProperty(context, globalObject, node, JSObjectMakeConstructor(context, JSNode_construct), kJSPropertyAttributeNone);
+    JSObjectSetProperty(context, globalObject, node, JSObjectMakeConstructor(context, JSNode_construct), kJSPropertyAttributeNone, NULL);
     JSStringRelease(node);