Changeset 154457 in webkit for trunk/Source/JavaScriptCore/runtime/ExceptionHelpers.cpp

Timestamp:

Aug 22, 2013, 12:44:20 PM (12 years ago)

Author:

[email protected]

Message:

errorDescriptionForValue() should not assume error value is an Object
​https://bugs.webkit.org/show_bug.cgi?id=119812

Patch by Chris Curtis <​[email protected]> on 2013-08-22
Reviewed by Geoffrey Garen.

Added a check to make sure that the JSValue was an object before casting it as an object. Also, in case the parameterized JSValue
has no type, the function now returns the empty string.

• runtime/ExceptionHelpers.cpp:

(JSC::errorDescriptionForValue):

File:

• trunk/Source/JavaScriptCore/runtime/ExceptionHelpers.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/ExceptionHelpers.cpp

@@ -107 +107 @@
         if (object->methodTable()->getCallData(object, callData) != CallTypeNone)
             return vm.smallStrings.functionString();
+        return jsString(exec, object->methodTable()->className(object));
     }
-    return jsString(exec, asObject(v)->methodTable()->className(asObject(v)));
+    
+    ASSERT(v.isEmpty());
+    // FIXME: https://bugs.webkit.org/show_bug.cgi?id=120080 The JSValue should never be empty in this function.
+    return vm.smallStrings.emptyString();
 }