Changeset 154459 in webkit for trunk/Source/JavaScriptCore/API/JSObjectRef.cpp

Timestamp:

Aug 22, 2013, 1:35:09 PM (12 years ago)

Author:

[email protected]

Message:

​https://bugs.webkit.org/show_bug.cgi?id=120128
Remove putDirectVirtual

Reviewed by Sam Weinig.

This could most generously be described as 'vestigial'.
No performance impact.

• API/JSObjectRef.cpp:

(JSObjectSetProperty):

• changed to use defineOwnProperty

• debugger/DebuggerActivation.cpp:
• debugger/DebuggerActivation.h:
  • remove putDirectVirtual
• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

• changed to use defineOwnProperty

• runtime/ClassInfo.h:
• runtime/JSActivation.cpp:
• runtime/JSActivation.h:
• runtime/JSCell.cpp:
• runtime/JSCell.h:
• runtime/JSGlobalObject.cpp:
• runtime/JSGlobalObject.h:
• runtime/JSObject.cpp:
• runtime/JSObject.h:
• runtime/JSProxy.cpp:
• runtime/JSProxy.h:
• runtime/JSSymbolTableObject.cpp:
• runtime/JSSymbolTableObject.h:
  • remove putDirectVirtual
• runtime/PropertyDescriptor.h:

(JSC::PropertyDescriptor::PropertyDescriptor):

• added constructor for convenience

File:

• trunk/Source/JavaScriptCore/API/JSObjectRef.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSObjectRef.cpp

@@ -328 +328 @@
     JSValue jsValue = toJS(exec, value);
 
-    if (attributes && !jsObject->hasProperty(exec, name))
-        jsObject->methodTable()->putDirectVirtual(jsObject, exec, name, jsValue, attributes);
-    else {
+    if (attributes && !jsObject->hasProperty(exec, name)) {
+        PropertyDescriptor desc(jsValue, attributes);
+        jsObject->methodTable()->defineOwnProperty(jsObject, exec, name, desc, false);
+    } else {
         PutPropertySlot slot;
         jsObject->methodTable()->put(jsObject, exec, name, jsValue, slot);