Changeset 154459 in webkit for trunk/Source/JavaScriptCore/runtime/ClassInfo.h

Timestamp:

Aug 22, 2013, 1:35:09 PM (12 years ago)

Author:

[email protected]

Message:

​https://bugs.webkit.org/show_bug.cgi?id=120128
Remove putDirectVirtual

Reviewed by Sam Weinig.

This could most generously be described as 'vestigial'.
No performance impact.

• API/JSObjectRef.cpp:

(JSObjectSetProperty):

• changed to use defineOwnProperty

• debugger/DebuggerActivation.cpp:
• debugger/DebuggerActivation.h:
  • remove putDirectVirtual
• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

• changed to use defineOwnProperty

• runtime/ClassInfo.h:
• runtime/JSActivation.cpp:
• runtime/JSActivation.h:
• runtime/JSCell.cpp:
• runtime/JSCell.h:
• runtime/JSGlobalObject.cpp:
• runtime/JSGlobalObject.h:
• runtime/JSObject.cpp:
• runtime/JSObject.h:
• runtime/JSProxy.cpp:
• runtime/JSProxy.h:
• runtime/JSSymbolTableObject.cpp:
• runtime/JSSymbolTableObject.h:
  • remove putDirectVirtual
• runtime/PropertyDescriptor.h:

(JSC::PropertyDescriptor::PropertyDescriptor):

• added constructor for convenience

File:

• trunk/Source/JavaScriptCore/runtime/ClassInfo.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/ClassInfo.h

@@ -90 +90 @@
     CustomHasInstanceFunctionPtr customHasInstance;
 
-    typedef void (*PutWithAttributesFunctionPtr)(JSObject*, ExecState*, PropertyName propertyName, JSValue, unsigned attributes);
-    PutWithAttributesFunctionPtr putDirectVirtual;
-
     typedef bool (*DefineOwnPropertyFunctionPtr)(JSObject*, ExecState*, PropertyName, const PropertyDescriptor&, bool);
     DefineOwnPropertyFunctionPtr defineOwnProperty;
@@ -141 +138 @@
         &ClassName::className, \
         &ClassName::customHasInstance, \
-        &ClassName::putDirectVirtual, \
         &ClassName::defineOwnProperty, \
         &ClassName::slowDownAndWasteMemory, \