Changeset 154459 in webkit for trunk/Source/JavaScriptCore/runtime/JSActivation.cpp

Timestamp:

Aug 22, 2013, 1:35:09 PM (12 years ago)

Author:

[email protected]

Message:

​https://bugs.webkit.org/show_bug.cgi?id=120128
Remove putDirectVirtual

Reviewed by Sam Weinig.

This could most generously be described as 'vestigial'.
No performance impact.

• API/JSObjectRef.cpp:

(JSObjectSetProperty):

• changed to use defineOwnProperty

• debugger/DebuggerActivation.cpp:
• debugger/DebuggerActivation.h:
  • remove putDirectVirtual
• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

• changed to use defineOwnProperty

• runtime/ClassInfo.h:
• runtime/JSActivation.cpp:
• runtime/JSActivation.h:
• runtime/JSCell.cpp:
• runtime/JSCell.h:
• runtime/JSGlobalObject.cpp:
• runtime/JSGlobalObject.h:
• runtime/JSObject.cpp:
• runtime/JSObject.h:
• runtime/JSProxy.cpp:
• runtime/JSProxy.h:
• runtime/JSSymbolTableObject.cpp:
• runtime/JSSymbolTableObject.h:
  • remove putDirectVirtual
• runtime/PropertyDescriptor.h:

(JSC::PropertyDescriptor::PropertyDescriptor):

• added constructor for convenience

File:

• trunk/Source/JavaScriptCore/runtime/JSActivation.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSActivation.cpp

@@ -194 +194 @@
 }
 
-// FIXME: Make this function honor ReadOnly (const) and DontEnum
-void JSActivation::putDirectVirtual(JSObject* object, ExecState* exec, PropertyName propertyName, JSValue value, unsigned attributes)
-{
-    JSActivation* thisObject = jsCast<JSActivation*>(object);
-    ASSERT(!Heap::heap(value) || Heap::heap(value) == Heap::heap(thisObject));
-
-    if (thisObject->symbolTablePutWithAttributes(exec->vm(), propertyName, value, attributes))
-        return;
-
-    // We don't call through to JSObject because __proto__ and getter/setter 
-    // properties are non-standard extensions that other implementations do not
-    // expose in the activation object.
-    ASSERT(!thisObject->hasGetterSetterProperties());
-    JSObject::putDirectVirtual(thisObject, exec, propertyName, value, attributes);
-}
-
 bool JSActivation::deleteProperty(JSCell* cell, ExecState* exec, PropertyName propertyName)
 {