Changeset 15462 in webkit for trunk/JavaScriptCore/API/JSClassRef.h

Timestamp:

Jul 15, 2006, 6:28:25 PM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Moved the arguments passed to JSClassCreate into a single structure, called JSClassDefinition. This will enable easier structure migration/versioning in the future, if necessary.

• Added support for class names.

• kJSClassDefinitionNull replaces kJSObjectCallbacksNone.

• JSClass is becoming a fairly complex struct, so I migrated all of its implementation other than reference counting to the sruct.

• Also moved JSClass* functions in the API to JSObjectRef.cpp, since they're declared in JSObjectRef.h

• Also added some more informative explanation to the class structure doc.

File:

• trunk/JavaScriptCore/API/JSClassRef.h (modified) (1 diff)

trunk/JavaScriptCore/API/JSClassRef.h

@@ -54 +54 @@
 
 struct __JSClass {
-    __JSClass() 
-        : refCount(0), staticValues(0), staticFunctions(0)
-    {
-    }
-    
-    unsigned refCount;
+    __JSClass(JSClassDefinition*);
+    ~__JSClass();
     
     typedef HashMap<RefPtr<KJS::UString::Rep>, StaticValueEntry*> StaticValuesTable;
+    typedef HashMap<RefPtr<KJS::UString::Rep>, StaticFunctionEntry*> StaticFunctionsTable;
+
+    unsigned refCount;
+
+    KJS::UString className;
+    __JSClass* parentClass;
+        
     StaticValuesTable* staticValues;
-
-    typedef HashMap<RefPtr<KJS::UString::Rep>, StaticFunctionEntry*> StaticFunctionsTable;
     StaticFunctionsTable* staticFunctions;
-
-    KJS::UString name; // FIXME: Not used yet
-    JSObjectCallbacks callbacks;
-    __JSClass* parent;
+    
+    JSObjectInitializeCallback initialize;
+    JSObjectFinalizeCallback finalize;
+    JSObjectHasPropertyCallback hasProperty;
+    JSObjectGetPropertyCallback getProperty;
+    JSObjectSetPropertyCallback setProperty;
+    JSObjectDeletePropertyCallback deleteProperty;
+    JSObjectAddPropertiesToListCallback addPropertiesToList;
+    JSObjectCallAsFunctionCallback callAsFunction;
+    JSObjectCallAsConstructorCallback callAsConstructor;
+    JSObjectHasInstanceCallback hasInstance;
+    JSObjectConvertToTypeCallback convertToType;
 };