Changeset 15462 in webkit for trunk/JavaScriptCore/API/JSNode.c

Timestamp:

Jul 15, 2006, 6:28:25 PM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Moved the arguments passed to JSClassCreate into a single structure, called JSClassDefinition. This will enable easier structure migration/versioning in the future, if necessary.

• Added support for class names.

• kJSClassDefinitionNull replaces kJSObjectCallbacksNone.

• JSClass is becoming a fairly complex struct, so I migrated all of its implementation other than reference counting to the sruct.

• Also moved JSClass* functions in the API to JSObjectRef.cpp, since they're declared in JSObjectRef.h

• Also added some more informative explanation to the class structure doc.

File:

• trunk/JavaScriptCore/API/JSNode.c (modified) (2 diffs)

trunk/JavaScriptCore/API/JSNode.c

@@ -108 +108 @@
 static JSClassRef JSNodePrototype_class(JSContextRef context)
 {
-    static JSClassRef nodePrototypeClass;
-    if (!nodePrototypeClass)
-        nodePrototypeClass = JSClassCreate(NULL, JSNodePrototype_staticFunctions, &kJSObjectCallbacksNone, NULL);
-    return nodePrototypeClass;
+    static JSClassRef jsClass;
+    if (!jsClass) {
+        JSClassDefinition definition = kJSClassDefinitionNull;
+        definition.staticFunctions = JSNodePrototype_staticFunctions;
+        jsClass = JSClassCreate(&definition);
+    }
+    return jsClass;
 }
 
@@ -164 +167 @@
 static JSClassRef JSNode_class(JSContextRef context)
 {
-    static JSClassRef nodeClass;
-    if (!nodeClass) {
-        JSObjectCallbacks JSNode_callbacks = kJSObjectCallbacksNone;
-        JSNode_callbacks.finalize = JSNode_finalize;
-        
-        nodeClass = JSClassCreate(JSNode_staticValues, NULL, &JSNode_callbacks, NULL);
-    }
-    return nodeClass;
+    static JSClassRef jsClass;
+    if (!jsClass) {
+        JSClassDefinition definition = kJSClassDefinitionNull;
+        definition.staticValues = JSNode_staticValues;
+        definition.finalize = JSNode_finalize;
+
+        jsClass = JSClassCreate(&definition);
+    }
+    return jsClass;
 }