Changeset 15482 in webkit for trunk/JavaScriptCore/API/JSCallbackConstructor.h

Timestamp:

Jul 17, 2006, 1:20:28 AM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Changed JSObjectMakeConstructor to JSObjectMakeConstructorWithCallback, to match JSObjectMakeFunctionWithCallback.

• Added prototype parameter, so the generated constructor automatically works with hasInstance / instanceof

• Moved hasInstance implementation from InternalFunctionImp to JSObject so that subclasses can inherit it without inheriting function-related baggage. More refactoring here would be good, but this seems like a good short-term solution.

(KJS::JSCallbackFunction::implementsHasInstance): override and return false,
because callback functions aren't constructors.

File:

• trunk/JavaScriptCore/API/JSCallbackConstructor.h (modified) (2 diffs)

trunk/JavaScriptCore/API/JSCallbackConstructor.h

@@ -29 +29 @@
 
 #include "JSObjectRef.h"
-#include "object.h"
+#include <kjs/object.h>
 
 namespace KJS {
-    
+
 class JSCallbackConstructor : public JSObject
 {
@@ -38 +38 @@
     JSCallbackConstructor(ExecState* exec, JSObjectCallAsConstructorCallback callback);
     
+    virtual bool implementsHasInstance() const;
+    
     virtual bool implementsConstruct() const;
     virtual JSObject* construct(ExecState*, const List &args);
-
+    
     virtual const ClassInfo *classInfo() const { return &info; }
     static const ClassInfo info;