Changeset 15482 in webkit for trunk/JavaScriptCore/API/minidom.c

Timestamp:

Jul 17, 2006, 1:20:28 AM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Changed JSObjectMakeConstructor to JSObjectMakeConstructorWithCallback, to match JSObjectMakeFunctionWithCallback.

• Added prototype parameter, so the generated constructor automatically works with hasInstance / instanceof

• Moved hasInstance implementation from InternalFunctionImp to JSObject so that subclasses can inherit it without inheriting function-related baggage. More refactoring here would be good, but this seems like a good short-term solution.

(KJS::JSCallbackFunction::implementsHasInstance): override and return false,
because callback functions aren't constructors.

File:

• trunk/JavaScriptCore/API/minidom.c (modified) (1 diff)

trunk/JavaScriptCore/API/minidom.c

@@ -45 +45 @@
     
     JSStringRef node = JSStringCreateWithUTF8CString("Node");
-    JSObjectSetProperty(context, globalObject, node, JSObjectMakeConstructor(context, JSNode_construct), kJSPropertyAttributeNone, NULL);
+    JSObjectSetProperty(context, globalObject, node, JSObjectMakeConstructorWithCallback(context, JSNode_prototype(context), JSNode_construct), kJSPropertyAttributeNone, NULL);
     JSStringRelease(node);