Ignore:
Timestamp:
Jul 17, 2006, 1:20:28 AM (19 years ago)
Author:
ggaren
Message:

Reviewed by Maciej.


  • Changed JSObjectMakeConstructor to JSObjectMakeConstructorWithCallback, to match JSObjectMakeFunctionWithCallback.


  • Added prototype parameter, so the generated constructor automatically works with hasInstance / instanceof


  • Moved hasInstance implementation from InternalFunctionImp to JSObject so that subclasses can inherit it without inheriting function-related baggage. More refactoring here would be good, but this seems like a good short-term solution.

(KJS::JSCallbackFunction::implementsHasInstance): override and return false,
because callback functions aren't constructors.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/JavaScriptCore.exp

    r15480 r15482  
    2424_JSObjectIsFunction
    2525_JSObjectMake
    26 _JSObjectMakeConstructor
     26_JSObjectMakeConstructorWithCallback
    2727_JSObjectMakeFunctionWithCallback
    2828_JSObjectMakeFunction
    … …  
    149149__ZN3KJS17PropertyNameArray3addERKNS_10IdentifierE
    150150__ZN3KJS18lengthPropertyNameE
    151 __ZN3KJS19InternalFunctionImp11hasInstanceEPNS_9ExecStateEPNS_7JSValueE
    152151__ZN3KJS19InternalFunctionImp4infoE
    153152__ZN3KJS19InternalFunctionImpC2EPNS_17FunctionPrototypeERKNS_10IdentifierE
Note: See TracChangeset for help on using the changeset viewer.