Changeset 15484 in webkit for trunk/JavaScriptCore/API/minidom.js

Timestamp:

Jul 17, 2006, 3:49:28 AM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Removed the exception parameter from the initialize callback and, by extension, JSObjectMake. We have never had a need for exceptions when iniitializing, so the parameter seemed likely to "get in the way."

Also, an exception in JavaScript is thrown in response to input --
"invalid URL", "index not a number", etc., so it's the job of the
constructor function, not the initialize method, to throw.

If initialize *really* wants to throw, it can communicate the throw to
the constructor through the constructed object's private data (e.g., set
it to NULL, signaling to the consntructor that initialization failed.)

• Added JSObjectMakeWithData, which enables a constructor to set private data on an object *before* it has been initialized. That way, the initialize methods can properly operate on the data.

• API/JSNode.c: Moved ref into the initialize method, for better encapsulation, now that it's possible.
• API/JSNodeList.c: ditto
• API/minidom.c: (main): Do more aggressive garbage collection to test ref/deref and initialize/finalize.
• API/minidom.js: store childNodes in a temporary so it doesn't get re-created like a thousand times. This makes debugging ref/deref easier

File:

• trunk/JavaScriptCore/API/minidom.js (modified) (2 diffs)

trunk/JavaScriptCore/API/minidom.js

@@ -199 +199 @@
     node.appendChild(child2);
 
-    for (var i = 0; i < node.childNodes.length + 1; i++) {
-        print("item " + i + ": " + node.childNodes.item(i));
-    }
-    
-    for (var i = 0; i < node.childNodes.length + 1; i++) {
-        print(i + ": " + node.childNodes[i]);
+    var childNodes = node.childNodes;
+    
+    for (var i = 0; i < childNodes.length + 1; i++) {
+        print("item " + i + ": " + childNodes.item(i));
+    }
+    
+    for (var i = 0; i < childNodes.length + 1; i++) {
+        print(i + ": " + childNodes[i]);
     }
 
@@ -210 +212 @@
     node.replaceChild(child3, child2);
     
-    for (var i = 0; i < node.childNodes.length + 1; i++) {
-        print("item " + i + ": " + node.childNodes.item(i));
-    }
-
-    for (var i = 0; i < node.childNodes.length + 1; i++) {
-        print(i + ": " + node.childNodes[i]);
+    for (var i = 0; i < childNodes.length + 1; i++) {
+        print("item " + i + ": " + childNodes.item(i));
+    }
+
+    for (var i = 0; i < childNodes.length + 1; i++) {
+        print(i + ": " + childNodes[i]);
     }