Changeset 154877 in webkit for trunk/Source/WebCore/xml/XMLSerializer.cpp

Timestamp:

Aug 30, 2013, 7:30:12 AM (12 years ago)

Author:

[email protected]

Message:

Node::document() should return a reference.
<​https://webkit.org/b/120496>

Reviewed by Antti Koivisto.

Now that orphan DocumentType nodes also have document pointers, it's no longer
possible to have a null Node::document().

Cement this by making document() return a reference, and remove the various
null checks exposed by this.

File:

• trunk/Source/WebCore/xml/XMLSerializer.cpp (modified) (1 diff)

trunk/Source/WebCore/xml/XMLSerializer.cpp

@@ -28 +28 @@
 namespace WebCore {
 
-String XMLSerializer::serializeToString(Node* node, ExceptionCode& ec)
+String XMLSerializer::serializeToString(Node* node, ExceptionCode&)
 {
     if (!node)
         return String();
-
-    if (!node->document()) {
-        // Due to the fact that DocumentType nodes are created by the DOMImplementation
-        // and not the Document, it is possible for it to not have a Document associated
-        // with it.  It should be the only type of node where this is possible.
-        ASSERT(node->nodeType() == Node::DOCUMENT_TYPE_NODE);
-
-        ec = INVALID_ACCESS_ERR;
-        return String();
-    }
-
     return createMarkup(node, IncludeNode, 0, DoNotResolveURLs, 0, XMLFragmentSerialization);
 }