Changeset 154877 in webkit for trunk/Source/WebCore/xml/XPathExpression.cpp

Timestamp:

Aug 30, 2013, 7:30:12 AM (12 years ago)

Author:

[email protected]

Message:

Node::document() should return a reference.
<​https://webkit.org/b/120496>

Reviewed by Antti Koivisto.

Now that orphan DocumentType nodes also have document pointers, it's no longer
possible to have a null Node::document().

Cement this by making document() return a reference, and remove the various
null checks exposed by this.

File:

• trunk/Source/WebCore/xml/XPathExpression.cpp (modified) (1 diff)

trunk/Source/WebCore/xml/XPathExpression.cpp

@@ -71 +71 @@
     evaluationContext.position = 1;
     evaluationContext.hadTypeConversionError = false;
-    RefPtr<XPathResult> result = XPathResult::create(contextNode->document(), m_topExpression->evaluate());
+    RefPtr<XPathResult> result = XPathResult::create(&contextNode->document(), m_topExpression->evaluate());
     evaluationContext.node = 0; // Do not hold a reference to the context node, as this may prevent the whole document from being destroyed in time.