Changeset 154892 in webkit for trunk/Source/JavaScriptCore/runtime/ExceptionHelpers.cpp

Timestamp:

Aug 30, 2013, 10:02:48 AM (12 years ago)

Author:

[email protected]

Message:

Cleaning errorDescriptionForValue after r154839
​https://bugs.webkit.org/show_bug.cgi?id=120531

Patch by Chris Curtis <​[email protected]> on 2013-08-30
Reviewed by Darin Adler.

Changed the assert to ASSERT_NOT_REACHED, now that r154839 has landed. errorDescriptionForValue
can assert again that the parameterized JSValue is !isEmpty().

• runtime/ExceptionHelpers.cpp:

(JSC::errorDescriptionForValue):

File:

• trunk/Source/JavaScriptCore/runtime/ExceptionHelpers.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/ExceptionHelpers.cpp

@@ -110 +110 @@
     }
     
-    ASSERT(v.isEmpty());
-    // FIXME: https://bugs.webkit.org/show_bug.cgi?id=120080 The JSValue should never be empty in this function.
+    // The JSValue should never be empty, so this point in the code should never be reached.
+    ASSERT_NOT_REACHED();
     return vm.smallStrings.emptyString();
 }