Changeset 155075 in webkit for trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp

Timestamp:

Sep 4, 2013, 3:33:57 PM (12 years ago)

Author:

[email protected]

Message:

Refining the StackIterator callback interface.
​https://bugs.webkit.org/show_bug.cgi?id=120695.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Introduce CallFrame::iterate() which instantiates a StackIterator and
invoke its iterate() method with the passed in functor. The only place
where the client code gets access to the StackIterator now is as an
argument to the client's functor.

• API/JSContextRef.cpp:

(JSContextCreateBacktrace):

• interpreter/CallFrame.cpp:
• interpreter/CallFrame.h:

(JSC::ExecState::iterate):

• interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::unwind):

• interpreter/StackIterator.cpp:

(JSC::StackIterator::StackIterator):
(DebugPrintFrameFunctor::DebugPrintFrameFunctor):
(DebugPrintFrameFunctor::operator()):
(debugPrintCallFrame):
(debugPrintStack):

• interpreter/StackIterator.h:

(JSC::StackIterator::iterate):

• jsc.cpp:

(functionJSCStack):

• profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::addParentForConsoleStart):

• runtime/JSFunction.cpp:

(JSC::retrieveArguments):
(JSC::RetrieveCallerFunctionFunctor::operator()):
(JSC::retrieveCallerFunction):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):

Source/WebCore:

No new tests.

• bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::SendFunctor::SendFunctor):
(WebCore::SendFunctor::line):
(WebCore::SendFunctor::url):
(WebCore::SendFunctor::operator()):
(WebCore::JSXMLHttpRequest::send):

• bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

File:

• trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp

@@ -340 +340 @@
 
     DumpRegisterFunctor functor(it);
-    StackIterator iter = callFrame->begin();
-    iter.iterate(functor);
+    callFrame->iterate(functor);
 
     dataLogF("[CodeBlock]                | %10p | %p \n", it, callFrame->codeBlock());
@@ -553 +552 @@
 
     GetStackTraceFunctor functor(vm, results, maxStackSize);
-    StackIterator iter = callFrame->begin();
-    iter.iterate(functor);
+    callFrame->iterate(functor);
 }
 
@@ -641 +639 @@
     ASSERT(callFrame == vm.topCallFrame);
     UnwindFunctor functor(callFrame, exceptionValue, isTermination, codeBlock, handler);
-    StackIterator iter = callFrame->begin();
-    iter.iterate(functor);
+    callFrame->iterate(functor);
     if (!handler)
         return 0;