Changeset 155260 in webkit for trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp

Timestamp:

Sep 7, 2013, 2:13:55 PM (12 years ago)

Author:

[email protected]

Message:

FTL should support typed array GetByVal and related ops
​https://bugs.webkit.org/show_bug.cgi?id=120965

Reviewed by Oliver Hunt.

This adds support for typed array instantiations of the following DFG IR ops:

• GetByVal

• GetIndexedPropertyStorage

• CheckArray

• GetArrayLength

This also adds CheckArray for Int32/Double/Contiguous arrays.

• dfg/DFGArrayMode.cpp:

(JSC::DFG::toIndexingShape):

• dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::shapeMask):

• ftl/FTLAbbreviations.h:

(JSC::FTL::floatType):
(JSC::FTL::buildSExt):
(JSC::FTL::buildFPCast):

• ftl/FTLAbstractHeapRepository.h:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLCommonValues.cpp:

(JSC::FTL::CommonValues::CommonValues):

• ftl/FTLCommonValues.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetIndexedPropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compileCheckArray):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::isArrayType):
(JSC::FTL::LowerDFGToLLVM::hasClassInfo):

• ftl/FTLOutput.h:

(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::signExt):
(JSC::FTL::Output::fpCast):
(JSC::FTL::Output::loadFloat):

File:

• trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp

@@ -92 +92 @@
         // These are OK.
         break;
+    case GetIndexedPropertyStorage:
+        if (isTypedView(node->arrayMode().typedArrayType()))
+            break;
+        return CannotCompile;
+    case CheckArray:
+        switch (node->arrayMode().type()) {
+        case Array::Int32:
+        case Array::Double:
+        case Array::Contiguous:
+            break;
+        default:
+            if (isTypedView(node->arrayMode().typedArrayType()))
+                break;
+            return CannotCompile;
+        }
+        break;
     case GetArrayLength:
         switch (node->arrayMode().type()) {
@@ -99 +115 @@
             break;
         default:
+            if (isTypedView(node->arrayMode().typedArrayType()))
+                break;
             return CannotCompile;
         }
@@ -111 +129 @@
             break;
         default:
+            if (isTypedView(node->arrayMode().typedArrayType()))
+                return CanCompileAndOSREnter;
             return CannotCompile;
         }