Changeset 155317 in webkit for trunk/Source/JavaScriptCore/heap/GCThreadSharedData.cpp

Timestamp:

Sep 8, 2013, 5:11:57 PM (12 years ago)

Author:

[email protected]

Message:

Calculating the size of the Heap should not require walking over it
​https://bugs.webkit.org/show_bug.cgi?id=120910

Reviewed by Geoffrey Garen.

Currently Heap::size() is O(sizeof(Heap)). This is too expensive to
call during a collection. We should keep a count of visited and copied
bytes as each collection progresses so as to avoid re-walking the Heap
at the end of collection.

• heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::childBytesVisited):
(JSC::GCThreadSharedData::childBytesCopied):

• heap/GCThreadSharedData.h:
• heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markRoots):
(JSC::Heap::sizeAfterCollect):
(JSC::Heap::collect):

• heap/Heap.h:
• heap/SlotVisitor.cpp:

(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::reset):

• heap/SlotVisitor.h:

(JSC::SlotVisitor::bytesVisited):
(JSC::SlotVisitor::bytesCopied):

• heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::copyLater):

File:

• trunk/Source/JavaScriptCore/heap/GCThreadSharedData.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/heap/GCThreadSharedData.cpp

@@ -51 +51 @@
     return result;
 }
+
+size_t GCThreadSharedData::childBytesVisited()
+{       
+    size_t result = 0;
+    for (unsigned i = 0; i < m_gcThreads.size(); ++i)
+        result += m_gcThreads[i]->slotVisitor()->bytesVisited();
+    return result;
+}
+
+size_t GCThreadSharedData::childBytesCopied()
+{       
+    size_t result = 0;
+    for (unsigned i = 0; i < m_gcThreads.size(); ++i)
+        result += m_gcThreads[i]->slotVisitor()->bytesCopied();
+    return result;
+}
 #endif