Changeset 155418 in webkit for trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp

Timestamp:

Sep 9, 2013, 11:01:03 PM (12 years ago)

Author:

[email protected]

Message:

Change virtual register function arguments from unsigned to int
​https://bugs.webkit.org/show_bug.cgi?id=121055

Reviewed by Filip Pizlo.

This is a largely mechanical change. This changes function paramaters and local variables used to
represent bytecode operands from being unsigned to be int.

• bytecode/CodeOrigin.h:
• dfg/DFGByteCodeParser.cpp:
• jit/JIT.h:
• jit/JITArithmetic.cpp:
• jit/JITArithmetic32_64.cpp:
• jit/JITInlines.h:
• jit/JITOpcodes.cpp:
• jit/JITOpcodes32_64.cpp:
• jit/JITPropertyAccess.cpp:
• jit/JITPropertyAccess32_64.cpp:
• jit/JITStubCall.h:

File:

• trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp (modified) (9 diffs)

trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp

@@ -215 +215 @@
 
         // Must be a local.
-        return getLocal((unsigned)operand);
-    }
+        return getLocal(operand);
+    }
+
     Node* get(int operand)
     {
@@ -228 +229 @@
         return getDirect(m_inlineStackTop->remapOperand(operand));
     }
+
     enum SetMode { NormalSet, SetOnEntry };
     void setDirect(int operand, Node* value, SetMode setMode = NormalSet)
@@ -238 +240 @@
 
         // Must be a local.
-        setLocal((unsigned)operand, value, setMode);
-    }
+        setLocal(operand, value, setMode);
+    }
+
     void set(int operand, Node* value, SetMode setMode = NormalSet)
     {
@@ -260 +263 @@
 
     // Used in implementing get/set, above, where the operand is a local variable.
-    Node* getLocal(unsigned operand)
+    Node* getLocal(int operand)
     {
         unsigned local = operandToLocal(operand);
@@ -297 +300 @@
         return node;
     }
-    void setLocal(unsigned operand, Node* value, SetMode setMode = NormalSet)
+
+    void setLocal(int operand, Node* value, SetMode setMode = NormalSet)
     {
         unsigned local = operandToLocal(operand);
@@ -2090 +2094 @@
 
         case op_inc: {
-            unsigned srcDst = currentInstruction[1].u.operand;
+            int srcDst = currentInstruction[1].u.operand;
             Node* op = get(srcDst);
             set(srcDst, makeSafe(addToGraph(ArithAdd, op, one())));
@@ -2097 +2101 @@
 
         case op_dec: {
-            unsigned srcDst = currentInstruction[1].u.operand;
+            int srcDst = currentInstruction[1].u.operand;
             Node* op = get(srcDst);
             set(srcDst, makeSafe(addToGraph(ArithSub, op, one())));
@@ -2997 +3001 @@
 
         case op_resolve_scope: {
-            unsigned dst = currentInstruction[1].u.operand;
+            int dst = currentInstruction[1].u.operand;
             ResolveType resolveType = static_cast<ResolveType>(currentInstruction[3].u.operand);
             unsigned depth = currentInstruction[4].u.operand;
@@ -3024 +3028 @@
 
         case op_get_from_scope: {
-            unsigned dst = currentInstruction[1].u.operand;
+            int dst = currentInstruction[1].u.operand;
             unsigned scope = currentInstruction[2].u.operand;
             unsigned identifierNumber = m_inlineStackTop->m_identifierRemap[currentInstruction[3].u.operand];