Changeset 155480 in webkit for trunk/Source/JavaScriptCore/dfg/DFGAbstractValue.h

Timestamp:

Sep 10, 2013, 2:55:45 PM (12 years ago)

Author:

[email protected]

Message:

Introduce a SpecInt48 type and be more careful about what we mean by "Top"
​https://bugs.webkit.org/show_bug.cgi?id=121116

Reviewed by Oliver Hunt.

SpecInt48 will mean that we have something that would be a double if it was a JSValue,
but it's profitable to represent it as something other than a double.

SpecInt48AsDouble means that it has a value that could have been represented like
SpecInt48, but we're making a heuristic decision not to do it.

• bytecode/SpeculatedType.h:

(JSC::isInt48Speculation):

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):
(JSC::DFG::::clobberCapturedVars):

• dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::filter):

• dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::makeHeapTop):
(JSC::DFG::AbstractValue::makeBytecodeTop):
(JSC::DFG::AbstractValue::isHeapTop):
(JSC::DFG::AbstractValue::heapTop):
(JSC::DFG::AbstractValue::validateType):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::makeTop):

• dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):

• dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

• dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

File:

• trunk/Source/JavaScriptCore/dfg/DFGAbstractValue.h (modified) (6 diffs)

trunk/Source/JavaScriptCore/dfg/DFGAbstractValue.h

@@ -63 +63 @@
     bool operator!() const { return isClear(); }
     
-    void makeTop()
-    {
-        m_type |= SpecTop; // The state may have included SpecEmpty, in which case we want this to become SpecEmptyOrTop.
-        m_arrayModes = ALL_ARRAY_MODES;
-        m_currentKnownStructure.makeTop();
-        m_futurePossibleStructure.makeTop();
-        m_value = JSValue();
-        checkConsistency();
+    void makeHeapTop()
+    {
+        makeTop(SpecHeapTop);
+    }
+    
+    void makeBytecodeTop()
+    {
+        makeTop(SpecBytecodeTop);
     }
     
@@ -90 +90 @@
     }
     
-    bool isTop() const
-    {
-        return m_type == SpecTop && m_currentKnownStructure.isTop() && m_futurePossibleStructure.isTop();
+    bool isHeapTop() const
+    {
+        return (m_type | SpecHeapTop) == m_type && m_currentKnownStructure.isTop() && m_futurePossibleStructure.isTop();
     }
     
@@ -105 +105 @@
     }
     
-    static AbstractValue top()
+    static AbstractValue heapTop()
     {
         AbstractValue result;
-        result.makeTop();
+        result.makeHeapTop();
         return result;
     }
@@ -196 +196 @@
     bool validateType(JSValue value) const
     {
-        if (isTop())
+        if (isHeapTop())
             return true;
         
@@ -212 +212 @@
     bool validate(JSValue value) const
     {
-        if (isTop())
+        if (isHeapTop())
             return true;
         
@@ -364 +364 @@
     }
     
+    void makeTop(SpeculatedType top)
+    {
+        m_type |= top;
+        m_arrayModes = ALL_ARRAY_MODES;
+        m_currentKnownStructure.makeTop();
+        m_futurePossibleStructure.makeTop();
+        m_value = JSValue();
+        checkConsistency();
+    }
+    
     void setFuturePossibleStructure(Graph&, Structure* structure);