Changeset 155480 in webkit for trunk/Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp

Timestamp:

Sep 10, 2013, 2:55:45 PM (12 years ago)

Author:

[email protected]

Message:

Introduce a SpecInt48 type and be more careful about what we mean by "Top"
​https://bugs.webkit.org/show_bug.cgi?id=121116

Reviewed by Oliver Hunt.

SpecInt48 will mean that we have something that would be a double if it was a JSValue,
but it's profitable to represent it as something other than a double.

SpecInt48AsDouble means that it has a value that could have been represented like
SpecInt48, but we're making a heuristic decision not to do it.

• bytecode/SpeculatedType.h:

(JSC::isInt48Speculation):

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):
(JSC::DFG::::clobberCapturedVars):

• dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::filter):

• dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::makeHeapTop):
(JSC::DFG::AbstractValue::makeBytecodeTop):
(JSC::DFG::AbstractValue::isHeapTop):
(JSC::DFG::AbstractValue::heapTop):
(JSC::DFG::AbstractValue::validateType):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::makeTop):

• dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):

• dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

• dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

File:

• trunk/Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp

@@ -110 +110 @@
         root->valuesAtTail.argument(i).clear();
         if (m_graph.m_form == SSA) {
-            root->valuesAtHead.argument(i).makeTop();
+            root->valuesAtHead.argument(i).makeHeapTop();
             continue;
         }
@@ -117 +117 @@
         ASSERT(node->op() == SetArgument);
         if (!node->variableAccessData()->shouldUnboxIfPossible()) {
-            root->valuesAtHead.argument(i).makeTop();
+            root->valuesAtHead.argument(i).makeHeapTop();
             continue;
         }
@@ -130 +130 @@
             root->valuesAtHead.argument(i).setType(SpecCell);
         else
-            root->valuesAtHead.argument(i).makeTop();
+            root->valuesAtHead.argument(i).makeHeapTop();
     }
     for (size_t i = 0; i < root->valuesAtHead.numberOfLocals(); ++i) {
         Node* node = root->variablesAtHead.local(i);
         if (node && node->variableAccessData()->isCaptured())
-            root->valuesAtHead.local(i).makeTop();
+            root->valuesAtHead.local(i).makeHeapTop();
         else
             root->valuesAtHead.local(i).clear();