Changeset 155734 in webkit for trunk/Source/JavaScriptCore/API/JSStringRefCF.cpp

Timestamp:

Sep 13, 2013, 5:26:13 PM (12 years ago)

Author:

[email protected]

Message:

Avoid a couple of zero-sized fastMalloc calls
​https://bugs.webkit.org/show_bug.cgi?id=121333

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• API/JSStringRefCF.cpp:

(JSStringCopyCFString):
Return an empty constant CFStringRef if the JSStringRef is empty.

• runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
Don't allocate an empty m_jsStrings array if m_jsStringsSize is 0.

Source/WTF:

• wtf/text/StringBuffer.h:

(WTF::StringBuffer::StringBuffer):
Initialize m_data to null if m_length is null, and use Checked<size_t> to check for
overflow when multiplying m_length with the character size.

File:

• trunk/Source/JavaScriptCore/API/JSStringRefCF.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSStringRefCF.cpp

@@ -59 +59 @@
 CFStringRef JSStringCopyCFString(CFAllocatorRef alloc, JSStringRef string)
 {
+    if (!string->length())
+        return CFSTR("");
+
     return CFStringCreateWithCharacters(alloc, reinterpret_cast<const UniChar*>(string->characters()), string->length());
 }