Changeset 155811 in webkit for trunk/Source/WebCore/rendering/RenderMedia.cpp

Timestamp:

Sep 15, 2013, 7:13:55 AM (12 years ago)

Author:

[email protected]

Message:

CTTE: RenderMedia and RenderVideo are never anonymous.
<​https://webkit.org/b/121388>

Reviewed by Sam Weinig.

Codify the following:

• RenderMedia always has an HTMLMediaElement.
• RenderVideo always has an HTMLVideoElement.

None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.

File:

• trunk/Source/WebCore/rendering/RenderMedia.cpp (modified) (3 diffs)

trunk/Source/WebCore/rendering/RenderMedia.cpp

@@ -29 +29 @@
 #include "RenderMedia.h"
 
-#include "HTMLMediaElement.h"
 #include "RenderFlowThread.h"
 #include "RenderView.h"
@@ -36 +35 @@
 namespace WebCore {
 
-RenderMedia::RenderMedia(HTMLMediaElement* video)
-    : RenderImage(video)
+RenderMedia::RenderMedia(HTMLMediaElement& element)
+    : RenderImage(&element)
 {
     setImageResource(RenderImageResource::create());
 }
 
-RenderMedia::RenderMedia(HTMLMediaElement* video, const IntSize& intrinsicSize)
-    : RenderImage(video)
+RenderMedia::RenderMedia(HTMLMediaElement& element, const IntSize& intrinsicSize)
+    : RenderImage(&element)
 {
     setImageResource(RenderImageResource::create());
@@ -51 +50 @@
 RenderMedia::~RenderMedia()
 {
-}
-
-HTMLMediaElement* RenderMedia::mediaElement() const
-{ 
-    return toHTMLMediaElement(element()); 
 }