Changeset 155995 in webkit for trunk/Source/JavaScriptCore/dfg/DFGOSRExitCompiler.cpp

Timestamp:

Sep 17, 2013, 1:56:57 PM (12 years ago)

Author:

[email protected]

Message:

Don't GC while OSR compiling
​https://bugs.webkit.org/show_bug.cgi?id=121513

Reviewed by Mark Hahnenberg.

Fixes some rare crashes that I see in ConservativeRoots, while in a GC from OSR exit
compilation.

• dfg/DFGOSRExitCompiler.cpp:
• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileFTLOSRExit):

File:

• trunk/Source/JavaScriptCore/dfg/DFGOSRExitCompiler.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGOSRExitCompiler.cpp

@@ -62 +62 @@
     VM* vm = &exec->vm();
     
+    // It's sort of preferable that we don't GC while in here. Anyways, doing so wouldn't
+    // really be profitable.
+    DeferGCForAWhile deferGC(vm->heap);
+
     uint32_t exitIndex = vm->osrExitIndex;
     OSRExit& exit = codeBlock->jitCode()->dfg()->osrExit[exitIndex];