Changeset 156017 in webkit for trunk/Source/JavaScriptCore/dfg/DFGArrayMode.h

Timestamp:

Sep 17, 2013, 6:06:49 PM (12 years ago)

Author:

[email protected]

Message:

Use CheckStructure for checking the types of typed arrays whenever possible
​https://bugs.webkit.org/show_bug.cgi?id=121514

Reviewed by Oliver Hunt.

• bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::computeUpdatedPrediction):

• dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::refine):
(JSC::DFG::ArrayMode::originalArrayStructure):
(JSC::DFG::arrayClassToString):

• dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::ArrayMode):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShape):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::isOriginalTypedArrayStructure):

File:

• trunk/Source/JavaScriptCore/dfg/DFGArrayMode.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/dfg/DFGArrayMode.h

@@ -82 +82 @@
 enum Class {
     NonArray, // Definitely some object that is not a JSArray.
+    OriginalNonArray, // Definitely some object that is not a JSArray, but that object has the original structure.
     Array, // Definitely a JSArray, and may or may not have custom properties or have undergone some other bizarre transitions.
     OriginalArray, // Definitely a JSArray, and still has one of the primordial JSArray structures for the global object that this code block (possibly inlined code block) belongs to.
@@ -124 +125 @@
         u.asBytes.type = type;
         u.asBytes.arrayClass = Array::NonArray;
+        u.asBytes.speculation = Array::InBounds;
+        u.asBytes.conversion = Array::AsIs;
+    }
+    
+    ArrayMode(Array::Type type, Array::Class arrayClass)
+    {
+        u.asBytes.type = type;
+        u.asBytes.arrayClass = arrayClass;
         u.asBytes.speculation = Array::InBounds;
         u.asBytes.conversion = Array::AsIs;
@@ -418 +427 @@
         switch (arrayClass()) {
         case Array::NonArray:
+        case Array::OriginalNonArray:
             return asArrayModes(shape);
         case Array::Array: