Changeset 156125 in webkit for trunk/Source/WebCore/css/CSSValue.cpp

Timestamp:

Sep 19, 2013, 3:38:24 PM (12 years ago)

Author:

[email protected]

Message:

Remove superfluous CSSLinearTimingFunctionValue and use switch on TimingFunction::type() in more places
​https://bugs.webkit.org/show_bug.cgi?id=121589

Reviewed by Dean Jackson.

Replaced CSSLinearTimingFunctionValue by the identifier "linear" and used switch statements on
TimingFunction::type() in more places where we were branching on every type.

Merge ​https://chromium.googlesource.com/chromium/blink/+/5454f20c71090c35bdd1053e5cc572d5c0bdede7
Merge ​https://chromium.googlesource.com/chromium/blink/+/104ad42c523d32b67d108c6e59f4f27488fe38a5

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::createTimingFunctionValue):

• css/CSSTimingFunctionValue.cpp:
• css/CSSTimingFunctionValue.h:
• css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTimingFunction):

• css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

• css/CSSValue.h:

(WebCore::CSSValue::isCubicBezierTimingFunctionValue):

• page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::progress):

File:

• trunk/Source/WebCore/css/CSSValue.cpp (modified) (3 diffs)

trunk/Source/WebCore/css/CSSValue.cpp

@@ -204 +204 @@
         case ShadowClass:
             return compareCSSValues<ShadowValue>(*this, other);
-        case LinearTimingFunctionClass:
-            return compareCSSValues<CSSLinearTimingFunctionValue>(*this, other);
         case CubicBezierTimingFunctionClass:
             return compareCSSValues<CSSCubicBezierTimingFunctionValue>(*this, other);
@@ -308 +306 @@
     case ShadowClass:
         return static_cast<const ShadowValue*>(this)->customCSSText();
-    case LinearTimingFunctionClass:
-        return static_cast<const CSSLinearTimingFunctionValue*>(this)->customCSSText();
     case CubicBezierTimingFunctionClass:
         return static_cast<const CSSCubicBezierTimingFunctionValue*>(this)->customCSSText();
@@ -438 +434 @@
         delete static_cast<ShadowValue*>(this);
         return;
-    case LinearTimingFunctionClass:
-        delete static_cast<CSSLinearTimingFunctionValue*>(this);
-        return;
     case CubicBezierTimingFunctionClass:
         delete static_cast<CSSCubicBezierTimingFunctionValue*>(this);