Changeset 156404 in webkit for trunk/Source/WebCore/rendering/RenderTableRow.cpp

Timestamp:

Sep 25, 2013, 10:45:59 AM (12 years ago)

Author:

Antti Koivisto

Message:

REGRESSION (r156355) Links / interactive elements inside nested tables are unclickable
​https://bugs.webkit.org/show_bug.cgi?id=121904

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/table/hittest-self-painting.html

Original reduction by Philippe Wittenbergh.

• rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):

Tighten a bit.

(WebCore::RenderTableRow::nodeAtPoint):

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):

These flipped accidentally in r156355.

LayoutTests:

• fast/table/hittest-self-painting-expected.txt: Added.
• fast/table/hittest-self-painting.html: Added.

File:

• trunk/Source/WebCore/rendering/RenderTableRow.cpp (modified) (2 diffs)

trunk/Source/WebCore/rendering/RenderTableRow.cpp

@@ -82 +82 @@
             // This only happens when borders are collapsed, since they end up affecting the border sides of the cell
             // itself.
-            for (RenderBox* childBox = firstChildBox(); childBox; childBox = childBox->nextSiblingBox()) {
-                if (!childBox->isTableCell())
-                    continue;
-                childBox->setChildNeedsLayout(true, MarkOnlyThis);
-            }
+            for (RenderTableCell* cell = firstCell(); cell; cell = cell->nextCell())
+                cell->setChildNeedsLayout(true, MarkOnlyThis);
         }
     }
@@ -217 +214 @@
         // table-specific hit-test method (which we should do for performance reasons anyway),
         // then we can remove this check.
-        if (cell->hasSelfPaintingLayer()) {
+        if (!cell->hasSelfPaintingLayer()) {
             LayoutPoint cellPoint = flipForWritingModeForChild(cell, accumulatedOffset);
             if (cell->nodeAtPoint(request, result, locationInContainer, cellPoint, action)) {