Changeset 156497 in webkit for trunk/Source/JavaScriptCore/parser/Nodes.cpp

Timestamp:

Sep 26, 2013, 2:27:00 PM (12 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling out r156464 and r156480.
​http://trac.webkit.org/changeset/156464
​http://trac.webkit.org/changeset/156480
​https://bugs.webkit.org/show_bug.cgi?id=121981

Leaking too much and killi
ng buildbot. (Requested by xenon on
#webkit).

Source/JavaScriptCore:

• bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::paramString):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitExpressionInfo):

• bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitBytecode):
(JSC::FuncExprNode::emitBytecode):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::addVar):

• parser/NodeConstructors.h:

(JSC::CommaNode::CommaNode):
(JSC::ParameterNode::ParameterNode):
(JSC::ForInNode::ForInNode):

• parser/Nodes.cpp:

(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):

• parser/Nodes.h:

(JSC::CommaNode::append):
(JSC::ParameterNode::ident):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::identifiers):

• parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseVarDeclaration):
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseFormalParameters):
(JSC::::parseAssignmentExpression):

• parser/Parser.h:

(JSC::Scope::declareParameter):

• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::operatorStackPop):

• runtime/JSONObject.cpp:
• runtime/JSONObject.h:

LayoutTests:

• js/destructuring-assignment-expected.txt: Removed.
• js/destructuring-assignment.html: Removed.
• js/mozilla/strict/13.1-expected.txt:
• js/mozilla/strict/regress-532254-expected.txt:
• js/mozilla/strict/script-tests/13.1.js:
• js/regress/destructuring-arguments-expected.txt: Removed.
• js/regress/destructuring-arguments-length-expected.txt: Removed.
• js/regress/destructuring-arguments-length.html: Removed.
• js/regress/destructuring-arguments.html: Removed.
• js/regress/destructuring-swap-expected.txt: Removed.
• js/regress/destructuring-swap.html: Removed.
• js/regress/script-tests/destructuring-arguments-length.js: Removed.
• js/regress/script-tests/destructuring-arguments.js: Removed.
• js/regress/script-tests/destructuring-swap.js: Removed.
• js/script-tests/destructuring-assignment.js: Removed.
• sputnik/Conformance/13_Function_Definition/S13_A5.html:

File:

• trunk/Source/JavaScriptCore/parser/Nodes.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/parser/Nodes.cpp

@@ -158 +158 @@
         ++parameterCount;
 
-    size_t objectSize = sizeof(FunctionParameters) - sizeof(void*) + sizeof(DeconstructionPatternNode*) * parameterCount;
+    size_t objectSize = sizeof(FunctionParameters) - sizeof(void*) + sizeof(StringImpl*) * parameterCount;
     void* slot = fastMalloc(objectSize);
     return adoptRef(new (slot) FunctionParameters(firstParameter, parameterCount));
@@ -167 +167 @@
 {
     unsigned i = 0;
-    for (ParameterNode* parameter = firstParameter; parameter; parameter = parameter->nextParam()) {
-        auto pattern = parameter->pattern();
-        pattern->ref();
-        patterns()[i++] = pattern;
-    }
+    for (ParameterNode* parameter = firstParameter; parameter; parameter = parameter->nextParam())
+        new (&identifiers()[i++]) Identifier(parameter->ident());
 }
 
@@ -177 +174 @@
 {
     for (unsigned i = 0; i < m_size; ++i)
-        patterns()[i]->deref();
+        identifiers()[i].~Identifier();
 }