Changeset 156602 in webkit for trunk/Source/JavaScriptCore/runtime/Arguments.cpp

Timestamp:

Sep 28, 2013, 7:15:24 AM (12 years ago)

Author:

[email protected]

Message:

Pass VM instead of ExecState to JSFunction constructors.
<​https://webkit.org/b/122014>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

JSFunction doesn't need the ExecState for anything during its
construction, so reduce the amount of loads by just passing the
VM around instead.

Factored out putDirectNonIndexAccessor() from the existing
putDirectAccessor() to avoid snowballing the patch (and because
it's kinda neat to avoid the extra branch.)

JSC release binary size -= 9680 bytes.

Source/WebCore:

Updated for new JSFunction::create() signature.

File:

• trunk/Source/JavaScriptCore/runtime/Arguments.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/Arguments.cpp

@@ -107 +107 @@
         return;
 
+    VM& vm = exec->vm();
     m_overrodeCaller = true;
     PropertyDescriptor descriptor;
-    descriptor.setAccessorDescriptor(globalObject()->throwTypeErrorGetterSetter(exec), DontEnum | DontDelete | Accessor);
-    methodTable()->defineOwnProperty(this, exec, exec->propertyNames().caller, descriptor, false);
+    descriptor.setAccessorDescriptor(globalObject()->throwTypeErrorGetterSetter(vm), DontEnum | DontDelete | Accessor);
+    methodTable()->defineOwnProperty(this, exec, vm.propertyNames->caller, descriptor, false);
 }
 
@@ -117 +118 @@
     if (m_overrodeCallee)
         return;
-    
+
+    VM& vm = exec->vm();
     m_overrodeCallee = true;
     PropertyDescriptor descriptor;
-    descriptor.setAccessorDescriptor(globalObject()->throwTypeErrorGetterSetter(exec), DontEnum | DontDelete | Accessor);
-    methodTable()->defineOwnProperty(this, exec, exec->propertyNames().callee, descriptor, false);
+    descriptor.setAccessorDescriptor(globalObject()->throwTypeErrorGetterSetter(vm), DontEnum | DontDelete | Accessor);
+    methodTable()->defineOwnProperty(this, exec, vm.propertyNames->callee, descriptor, false);
 }