Changeset 156738 in webkit for trunk/Source/WebCore/rendering/RenderElement.cpp

Timestamp:

Oct 1, 2013, 3:29:34 PM (12 years ago)

Author:

Antti Koivisto

Message:

Make tests for renderer base types non-virtual
​https://bugs.webkit.org/show_bug.cgi?id=122185

Reviewed by Dave Hyatt.

Make isRenderFoo() functions for commonly tested base types use bit flags instead of virtual calls.
This is faster and we have space in RenderElement.

These bits are not mutully exclusive. For testing leaf types we can add an enum.

File:

• trunk/Source/WebCore/rendering/RenderElement.cpp (modified) (2 diffs)

trunk/Source/WebCore/rendering/RenderElement.cpp

@@ -65 +65 @@
 bool RenderElement::s_noLongerAffectsParentBlock = false;
 
-RenderElement::RenderElement(Element* element)
+RenderElement::RenderElement(Element* element, unsigned baseTypeFlags)
     : RenderObject(element)
+    , m_baseTypeFlags(baseTypeFlags)
     , m_ancestorLineBoxDirty(false)
     , m_firstChild(nullptr)
@@ -274 +275 @@
     // style changing, since it depends on whether we decide to composite these elements. When the
     // layer status of one of these elements changes, we need to force a layout.
-    if (diff == StyleDifferenceEqual && style() && isLayerModelObject()) {
+    if (diff == StyleDifferenceEqual && style() && isRenderLayerModelObject()) {
         if (hasLayer() != toRenderLayerModelObject(this)->requiresLayer())
             diff = StyleDifferenceLayout;