Changeset 156738 in webkit for trunk/Source/WebCore/rendering/RenderObject.h

Timestamp:

Oct 1, 2013, 3:29:34 PM (12 years ago)

Author:

Antti Koivisto

Message:

Make tests for renderer base types non-virtual
​https://bugs.webkit.org/show_bug.cgi?id=122185

Reviewed by Dave Hyatt.

Make isRenderFoo() functions for commonly tested base types use bit flags instead of virtual calls.
This is faster and we have space in RenderElement.

These bits are not mutully exclusive. For testing leaf types we can add an enum.

File:

• trunk/Source/WebCore/rendering/RenderObject.h (modified) (3 diffs)

trunk/Source/WebCore/rendering/RenderObject.h

@@ -304 +304 @@
 
     bool isRenderElement() const { return !isText(); }
-    virtual bool isBoxModelObject() const { return false; }
+    bool isRenderReplaced() const;
+    bool isBoxModelObject() const;
+    bool isRenderBlock() const;
+    bool isRenderBlockFlow() const;
+    bool isRenderInline() const;
+    bool isRenderLayerModelObject() const;
+
     virtual bool isCounter() const { return false; }
     virtual bool isQuote() const { return false; }
@@ -318 +324 @@
     virtual bool isImage() const { return false; }
     virtual bool isInlineBlockOrInlineTable() const { return false; }
-    virtual bool isLayerModelObject() const { return false; }
     virtual bool isListBox() const { return false; }
     virtual bool isListItem() const { return false; }
@@ -331 +336 @@
     virtual bool isProgress() const { return false; }
 #endif
-    virtual bool isRenderBlock() const { return false; }
-    virtual bool isRenderBlockFlow() const { return false; }
     virtual bool isRenderSVGBlock() const { return false; };
     virtual bool isRenderButton() const { return false; }
     virtual bool isRenderIFrame() const { return false; }
     virtual bool isRenderImage() const { return false; }
-    virtual bool isRenderInline() const { return false; }
     virtual bool isRenderRegion() const { return false; }
-    virtual bool isRenderReplaced() const { return false; }
     virtual bool isReplica() const { return false; }