Changeset 156757 in webkit for trunk/Source/JavaScriptCore/runtime/JSONObject.cpp

Timestamp:

Oct 1, 2013, 7:19:34 PM (12 years ago)

Author:

[email protected]

Message:

REGRESSION(156464): 50% regression on SunSpider/string-fasta
​https://bugs.webkit.org/show_bug.cgi?id=122202

Source/JavaScriptCore:

Unreviewed, roll out r156464.

This is a progression on string-fasta, since it fixes the regression.

• bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::paramString):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitExpressionInfo):

• bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitBytecode):
(JSC::FuncExprNode::emitBytecode):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::addVar):

• parser/NodeConstructors.h:

(JSC::CommaNode::CommaNode):
(JSC::ParameterNode::ParameterNode):
(JSC::ForInNode::ForInNode):

• parser/Nodes.cpp:

(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):

• parser/Nodes.h:

(JSC::ExpressionNode::isDotAccessorNode):
(JSC::CommaNode::append):
(JSC::ParameterNode::ident):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::identifiers):

• parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseVarDeclaration):
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseFormalParameters):
(JSC::::parseAssignmentExpression):

• parser/Parser.h:

(JSC::Scope::declareParameter):
(JSC::Parser::declareParameter):

• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::operatorStackPop):

• runtime/JSONObject.cpp:
• runtime/JSONObject.h:

LayoutTests:

Unreviewed, roll out r156464.

• js/destructuring-assignment-expected.txt: Removed.
• js/destructuring-assignment.html: Removed.
• js/mozilla/strict/13.1-expected.txt:
• js/mozilla/strict/regress-532254-expected.txt:
• js/mozilla/strict/script-tests/13.1.js:
• js/regress/destructuring-arguments-expected.txt: Removed.
• js/regress/destructuring-arguments-length-expected.txt: Removed.
• js/regress/destructuring-arguments-length.html: Removed.
• js/regress/destructuring-arguments.html: Removed.
• js/regress/destructuring-swap-expected.txt: Removed.
• js/regress/destructuring-swap.html: Removed.
• js/regress/script-tests/destructuring-arguments-length.js: Removed.
• js/regress/script-tests/destructuring-arguments.js: Removed.
• js/regress/script-tests/destructuring-swap.js: Removed.
• js/script-tests/destructuring-assignment.js: Removed.
• sputnik/Conformance/13_Function_Definition/S13_A5.html:

File:

• trunk/Source/JavaScriptCore/runtime/JSONObject.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSONObject.cpp

@@ -303 +303 @@
     }
 }
-
-void escapeStringToBuilder(StringBuilder& builder, const String& message)
-{
-    if (message.is8Bit())
-        appendStringToStringBuilder(builder, message.characters8(), message.length());
-    else
-        appendStringToStringBuilder(builder, message.characters16(), message.length());
-}
-
+    
 void Stringifier::appendQuotedString(StringBuilder& builder, const String& value)
 {