Changeset 156785 in webkit for trunk/Source/JavaScriptCore/parser/Nodes.cpp

Timestamp:

Oct 2, 2013, 12:11:04 PM (12 years ago)

Author:

[email protected]

Message:

Implement prefixed-destructuring assignment
​https://bugs.webkit.org/show_bug.cgi?id=121930

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Relanding with fix after rollout - it helps to not completely destroy
optimisations for no reason.

LayoutTests:

Relanding with fix after rollout - it helps to not completely destroy
optimisations for no reason.

File:

• trunk/Source/JavaScriptCore/parser/Nodes.cpp (modified) (3 diffs)

trunk/Source/JavaScriptCore/parser/Nodes.cpp

@@ -158 +158 @@
         ++parameterCount;
 
-    size_t objectSize = sizeof(FunctionParameters) - sizeof(void*) + sizeof(StringImpl*) * parameterCount;
+    size_t objectSize = sizeof(FunctionParameters) - sizeof(void*) + sizeof(DeconstructionPatternNode*) * parameterCount;
     void* slot = fastMalloc(objectSize);
     return adoptRef(new (slot) FunctionParameters(firstParameter, parameterCount));
@@ -167 +167 @@
 {
     unsigned i = 0;
-    for (ParameterNode* parameter = firstParameter; parameter; parameter = parameter->nextParam())
-        new (&identifiers()[i++]) Identifier(parameter->ident());
+    for (ParameterNode* parameter = firstParameter; parameter; parameter = parameter->nextParam()) {
+        auto pattern = parameter->pattern();
+        pattern->ref();
+        patterns()[i++] = pattern;
+    }
 }
 
@@ -174 +177 @@
 {
     for (unsigned i = 0; i < m_size; ++i)
-        identifiers()[i].~Identifier();
+        patterns()[i]->deref();
 }