Changeset 156891 in webkit for trunk/Source/WebCore/rendering/RenderLayer.cpp

Timestamp:

Oct 4, 2013, 9:02:46 AM (12 years ago)

Author:

[email protected]

Message:

[CSSRegions] Regions as stacking contexts should paint over positioned sibling
​https://bugs.webkit.org/show_bug.cgi?id=122321

Reviewed by Alexandru Chiculita.

Source/WebCore:

Test: fast/regions/layers/region-normalflow-stacking-context.html

Since regions are stacking contexts, they should not be in normal flow list of layers.
More clean-up after ​https://bugs.webkit.org/show_bug.cgi?id=117365 and ​https://bugs.webkit.org/show_bug.cgi?id=121828
which enabled the layers.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):

LayoutTests:

Add a new test and modify existing tests to take into account the stacking context behavior
for non-positioned regions.

• fast/regions/autoheight-regions-mark-expected.txt:
• fast/regions/layers/region-normalflow-stacking-context-expected.html: Added.
• fast/regions/layers/region-normalflow-stacking-context.html: Added.
• fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html:
• fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html:

File:

• trunk/Source/WebCore/rendering/RenderLayer.cpp (modified) (2 diffs)

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -5962 +5962 @@
         || renderer().isEmbeddedObject()
         || renderer().isRenderIFrame()
-        || renderer().isRenderRegion()
         || (renderer().style()->specifiesColumns() && !isRootLayer()))
         && !renderer().isPositioned()
@@ -5989 +5988 @@
         || renderer().isVideo()
         || renderer().isEmbeddedObject()
-        || renderer().isRenderIFrame()
-        || renderer().isRenderRegion();
+        || renderer().isRenderIFrame();
 }