Changeset 157150 in webkit for trunk/Source/JavaScriptCore/runtime/VM.h

Timestamp:

Oct 8, 2013, 5:24:38 PM (12 years ago)

Author:

[email protected]

Message:

Convert for-of iteration to in-band signalling so we can trivially avoid unnecessary object allocation
​https://bugs.webkit.org/show_bug.cgi?id=122532

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Switch for-of enumeration to use in band signalling to determine the end
of iteration. This allows us to trivially remove an otherwise unnecessary
object allocation, and paves the way for optimised thunks in future.

We can re-add explicit .next() functions in future that would marshall
the true iteration functions, but for now we'll ignore them.

This results in a huge improvement in the performance of for-of (in the order
of 2x) but there's still a long way to go in order to get the performance to
a satisfactory level.

• bytecompiler/NodesCodegen.cpp:

(JSC::ForOfNode::emitBytecode):

• runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::createIteratorResult):

• runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):

• runtime/CommonIdentifiers.h:
• runtime/Identifier.cpp:

(JSC::Identifier::addSlowCase):

• runtime/JSObject.h:

(JSC::JSFinalObject::create):

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

LayoutTests:

Update tests to reflect our non-exposure of .next()

• js/array-iterators-expected.txt:
• js/script-tests/array-iterators.js:

File:

• trunk/Source/JavaScriptCore/runtime/VM.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/VM.h

@@ -271 +271 @@
         Strong<Structure> mapDataStructure;
         Strong<Structure> weakMapDataStructure;
+        Strong<JSCell> iterationTerminator;
 
         IdentifierTable* identifierTable;