Ignore:
Timestamp:
Oct 14, 2013, 11:08:11 AM (12 years ago)
Author:
[email protected]
Message:

FTL should have an inefficient but correct implementation of GetById
https://bugs.webkit.org/show_bug.cgi?id=122740

Reviewed by Mark Hahnenberg.

It took some effort to realize that the node->prediction() check in the DFG backends
are completely unnecessary since the ByteCodeParser will always insert a ForceOSRExit
if !prediction.

But other than that this was an easy patch.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetById):

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r157404 r157409  
     12013-10-13  Filip Pizlo  <[email protected]>
     2
     3        FTL should have an inefficient but correct implementation of GetById
     4        https://bugs.webkit.org/show_bug.cgi?id=122740
     5
     6        Reviewed by Mark Hahnenberg.
     7       
     8        It took some effort to realize that the node->prediction() check in the DFG backends
     9        are completely unnecessary since the ByteCodeParser will always insert a ForceOSRExit
     10        if !prediction.
     11       
     12        But other than that this was an easy patch.
     13
     14        * dfg/DFGByteCodeParser.cpp:
     15        (JSC::DFG::ByteCodeParser::handleGetById):
     16        * dfg/DFGSpeculativeJIT32_64.cpp:
     17        (JSC::DFG::SpeculativeJIT::compile):
     18        * dfg/DFGSpeculativeJIT64.cpp:
     19        (JSC::DFG::SpeculativeJIT::compile):
     20        * ftl/FTLCapabilities.cpp:
     21        (JSC::FTL::canCompile):
     22        * ftl/FTLIntrinsicRepository.h:
     23        * ftl/FTLLowerDFGToLLVM.cpp:
     24        (JSC::FTL::LowerDFGToLLVM::compileNode):
     25        (JSC::FTL::LowerDFGToLLVM::compileGetById):
     26
    1272013-10-13  Mark Lam  <[email protected]>
    228
Note: See TracChangeset for help on using the changeset viewer.