Changeset 157409 in webkit for trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp

Timestamp:

Oct 14, 2013, 11:08:11 AM (12 years ago)

Author:

[email protected]

Message:

FTL should have an inefficient but correct implementation of GetById
​https://bugs.webkit.org/show_bug.cgi?id=122740

Reviewed by Mark Hahnenberg.

It took some effort to realize that the node->prediction() check in the DFG backends
are completely unnecessary since the ByteCodeParser will always insert a ForceOSRExit
if !prediction.

But other than that this was an easy patch.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLIntrinsicRepository.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetById):

File:

• trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ftl/FTLCapabilities.cpp

@@ -95 +95 @@
     case GetClosureVar:
     case PutClosureVar:
+    case GetById:
         // These are OK.
         break;