Ignore:
Timestamp:
Oct 14, 2013, 5:05:45 PM (12 years ago)
Author:
[email protected]
Message:

DFG PutById IC should use the ConcurrentJITLocker since it's now dealing with IC's that get read by the compiler thread
​https://bugs.webkit.org/show_bug.cgi?id=122786

Reviewed by Mark Hahnenberg.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStub): Resetting a stub should acquire the lock since this is observable from the thread; but we should only acquire the lock if we're resetting outside of GC.

  • jit/Repatch.cpp:

(JSC::repatchPutByID): Doing the PutById patching should hold the lock.
(JSC::buildPutByIdList): Ditto.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r157429 r157433  
     12013-10-14  Filip Pizlo  <[email protected]>
     2
     3        DFG PutById IC should use the ConcurrentJITLocker since it's now dealing with IC's that get read by the compiler thread
     4        https://bugs.webkit.org/show_bug.cgi?id=122786
     5
     6        Reviewed by Mark Hahnenberg.
     7
     8        * bytecode/CodeBlock.cpp:
     9        (JSC::CodeBlock::resetStub): Resetting a stub should acquire the lock since this is observable from the thread; but we should only acquire the lock if we're resetting outside of GC.
     10        * jit/Repatch.cpp:
     11        (JSC::repatchPutByID): Doing the PutById patching should hold the lock.
     12        (JSC::buildPutByIdList): Ditto.
     13
    1142013-10-14  Nadav Rotem  <[email protected]>
    215
Note: See TracChangeset for help on using the changeset viewer.