Changeset 15803 in webkit for trunk/JavaScriptCore/API/testapi.c

Timestamp:

Aug 4, 2006, 2:12:32 PM (19 years ago)

Author:

beidson

Message:

Reviewed by Geoff's rubber stamp

Fix a build break on Intel hardware causes by adapting stricter
compiler warnings (-Wshorten-64-to-32)

• API/testapi.c: (assertEqualsAsNumber): manually cast some doubles to floats (main): ditto

File:

• trunk/JavaScriptCore/API/testapi.c (modified) (2 diffs)

trunk/JavaScriptCore/API/testapi.c

@@ -47 +47 @@
 {
     double number = JSValueToNumber(context, value, NULL);
-    if (number != expectedValue && !(isnan(number) && isnan(expectedValue)))
+
+    // FIXME <rdar://4668451> - On i386 the isnan(double) macro tries to map to the isnan(float) function,
+    // causing a build break with -Wshorten-64-to-32 enabled.  The issue is known by the appropriate team.
+    // After that's resolved, we can remove these casts
+    if (number != expectedValue && !(isnan((float)number) && isnan((float)expectedValue)))
         fprintf(stderr, "assertEqualsAsNumber failed: %p, %lf\n", value, expectedValue);
 }
@@ -561 +565 @@
     
     exception = NULL;
-    assert(isnan(JSValueToNumber(context, jsObjectNoProto, &exception)));
+    // FIXME <rdar://4668451> - On i386 the isnan(double) macro tries to map to the isnan(float) function,
+    // causing a build break with -Wshorten-64-to-32 enabled.  The issue is known by the appropriate team.
+    // After that's resolved, we can remove these casts
+    assert(isnan((float)JSValueToNumber(context, jsObjectNoProto, &exception)));
     assert(exception);