Changeset 158097 in webkit for trunk/Source/WebCore/rendering/RenderWidget.cpp

Timestamp:

Oct 27, 2013, 3:54:07 PM (12 years ago)

Author:

[email protected]

Message:

Renderers should receive their style at construction.
<​https://webkit.org/b/123396>

Pass the RenderStyle to all non-text renderer constructors.
After construction, initializeStyle() must be called (as a stopgap
measure) until we are able to do style-derived initialization
without virtual function calls.

With this change, RenderElement::m_style is never null. Subsequent
patches will add enforcement for this and also make style() return
a RenderStyle&.

I'm adding three FIXME's in this patch:

• createRendererIfNeeded() calls AnimationController to set up the initial style manually instead of asking RenderElement's setAnimatedStyle() to do it. This can probably be done in a nicer way, but it's not clear yet how.

• ImageContentData::createRenderer() does a bit of unnecessary work. This should be easy to clean up but got too distracting to be part of this patch.

• Document::createRenderTree() creates the RenderView with an initial dummy RenderStyle. I've done this because resolving the document style assumes we already have a RenderView.

For styleWillChange() implementations to detect that they are
reacting to the initial style, I've added a hasInitializedStyle()
function on RenderElement. This will return false until you've
called initializeStyle() on the renderer. This should go away
along with initializeStyle() eventually.

Reviewed by Antti Koivisto.

File:

• trunk/Source/WebCore/rendering/RenderWidget.cpp (modified) (2 diffs)

trunk/Source/WebCore/rendering/RenderWidget.cpp

@@ -89 +89 @@
 }
 
-RenderWidget::RenderWidget(HTMLFrameOwnerElement& element)
-    : RenderReplaced(element)
+RenderWidget::RenderWidget(HTMLFrameOwnerElement& element, PassRef<RenderStyle> style)
+    : RenderReplaced(element, std::move(style))
     , m_weakPtrFactory(this)
 {
@@ -191 +191 @@
         // widget immediately, but we have to have really been fully constructed (with a non-null
         // style pointer).
-        if (style()) {
+        if (hasInitializedStyle()) {
             if (!needsLayout()) {
                 WeakPtr<RenderWidget> weakThis = createWeakPtr();