Changeset 158498 in webkit for trunk/Source/JavaScriptCore/runtime/Identifier.h

Timestamp:

Nov 2, 2013, 2:18:59 PM (12 years ago)

Author:

[email protected]

Message:

Make remaining StringImpl functions return PassRef.
<​https://webkit.org/b/123683>

Okay, this seems to work well! Let's go all in and convert the
remaining StringImpl functions to return PassRef<StringImpl> instead
of PassRefPtr where we know that null is never returned.

Reviewed by Anders Carlsson.

File:

• trunk/Source/JavaScriptCore/runtime/Identifier.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/Identifier.h

@@ -170 +170 @@
         {
             T* d;
-            StringImpl* r = StringImpl::createUninitialized(buf.length, d).leakRef();
+            StringImpl& r = StringImpl::createUninitialized(buf.length, d).leakRef();
             for (unsigned i = 0; i != buf.length; i++)
                 d[i] = buf.s[i];
-            r->setHash(hash);
-            location = r; 
+            r.setHash(hash);
+            location = &r;
         }
     };