Changeset 158561 in webkit for trunk/Source/WebCore/rendering/RenderFrameSet.cpp

Timestamp:

Nov 4, 2013, 12:46:06 AM (12 years ago)

Author:

[email protected]

Message:

Add an ancestor renderer iterator.
<​https://webkit.org/b/123718>

Add ancestor iterators for renderers, analogous to element ancestor
iterators. They walk the chain of parent renderers, stopping at each
ancestor of a certain type.

Just like child renderer iterators, this requires isRendererOfType()
to be implemented for the targeted renderer class.

You use them like this:

auto frameSets = ancestorsOfType<RenderFrameSet>(*this);
for (auto frameSet = frameSets.begin(), end = frameSets.end(); frameSet != end; ++frameSet)

frameSet->thisOrThat();

To complete the patch, I put them to use in a couple of random places.

Reviewed by Antti Koivisto.

File:

• trunk/Source/WebCore/rendering/RenderFrameSet.cpp (modified) (3 diffs)

trunk/Source/WebCore/rendering/RenderFrameSet.cpp

@@ -3 +3 @@
  *           (C) 2000 Simon Hausmann <[email protected]>
  *           (C) 2000 Stefan Schimanski ([email protected])
- * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
+ * Copyright (C) 2004, 2005, 2006, 2013 Apple Computer, Inc.
  *
  * This library is free software; you can redistribute it and/or
@@ -38 +38 @@
 #include "PaintInfo.h"
 #include "RenderFrame.h"
+#include "RenderIterator.h"
 #include "RenderLayer.h"
 #include "RenderView.h"
@@ -709 +710 @@
 {
     m_isResizing = isResizing;
-    for (auto ancestor = parent(); ancestor; ancestor = ancestor->parent()) {
-        if (ancestor->isFrameSet())
-            toRenderFrameSet(ancestor)->m_isChildResizing = isResizing;
-    }
+    auto ancestors = ancestorsOfType<RenderFrameSet>(*this);
+    for (auto ancestor = ancestors.begin(), end = ancestors.end(); ancestor != end; ++ancestor)
+        ancestor->m_isChildResizing = isResizing;
     frame().eventHandler().setResizingFrameSet(isResizing ? &frameSetElement() : 0);
 }