Changeset 159276 in webkit for trunk/Source/JavaScriptCore/offlineasm/arm.rb

Timestamp:

Nov 13, 2013, 11:39:30 PM (12 years ago)

Author:

[email protected]

Message:

Change callToJavaScript thunk into an offline assembled stub
​https://bugs.webkit.org/show_bug.cgi?id=124251

Reviewed by Geoffrey Garen.

Changed callToJavaScript and throwNotCaught into stubs generated by the offline assembler.
Added popCalleeSaves and pushCalleeSaves pseudo ops to the offline assembler to handle
the saving and restoring of callee save registers. Fixed callFrameRegister differences
between arm traditional (r11) and arm Thumb2 (r7) in GPRInfo.h. Also fixed implementation
of pop & push in arm.rb.

Since the offline assembler and therefore the LLInt don't work on Windows, the Windows stubs
are handled as inline assembly in JITStubsX86.h and JITStubsMSVC64.asm.

• dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

• jit/GPRInfo.h:

(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):

• jit/JITCode.cpp:

(JSC::JITCode::execute):

• jit/JITExceptions.cpp:

(JSC::genericUnwind):

• jit/JITStubs.h:
• jit/JITStubsMSVC64.asm:
• jit/JITStubsX86.h:
• jit/ThunkGenerators.cpp:
• jit/ThunkGenerators.h:
• llint/LLIntThunks.h:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• offlineasm/arm.rb:
• offlineasm/arm64.rb:
• offlineasm/instructions.rb:
• offlineasm/mips.rb:
• offlineasm/registers.rb:
• offlineasm/sh4.rb:
• offlineasm/x86.rb:
• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

File:

• trunk/Source/JavaScriptCore/offlineasm/arm.rb (modified) (2 diffs)

trunk/Source/JavaScriptCore/offlineasm/arm.rb

@@ -98 +98 @@
             "r4"
         when "t4"
-            "r10"
+            "r8"
+        when "t5"
+            "r9"
         when "cfr"
             isARMv7 ?  "r7" : "r11"
@@ -452 +454 @@
             raise "ARM does not support this opcode yet, #{codeOrigin}"
         when "pop"
-            $asm.puts "pop #{operands[0].armOperand}"
+            $asm.puts "pop { #{operands[0].armOperand} }"
         when "push"
-            $asm.puts "push #{operands[0].armOperand}"
+            $asm.puts "push { #{operands[0].armOperand} }"
+        when "popCalleeSaves"
+            if isARMv7
+                $asm.puts "pop {r4-r6, r8-r11}"                
+            else
+                $asm.puts "pop {r4-r10}"
+            end
+        when "pushCalleeSaves"
+            if isARMv7
+                $asm.puts "push {r4-r6, r8-r11}"
+            else
+                $asm.puts "push {r4-r10}"
+            end
         when "move"
             if operands[0].immediate?