Changeset 159288 in webkit for trunk/Source/JavaScriptCore/offlineasm/instructions.rb

Timestamp:

Nov 14, 2013, 8:52:48 AM (12 years ago)

Author:

[email protected]

Message:

REGRESSION (r159276): Fix lots of crashes for sh4 architecture.
​https://bugs.webkit.org/show_bug.cgi?id=124347

Patch by Julien Brianceau <​[email protected]> on 2013-11-14
Reviewed by Michael Saboff.

Since r159276, we have (t4 == a0 == r4) and (t5 == a1 == r5) in LLINT for sh4.
This leads to argument register trampling in cCallX macros, especially with cCall2
macro when arg1 == t4.

• llint/LowLevelInterpreter32_64.asm: Use a new "setargs" pseudo-op to setup arguments for sh4.
• offlineasm/instructions.rb:
• offlineasm/sh4.rb: Lower "setargs" pseudo-op to setup argument registers and prevent register trampling issues.

File:

• trunk/Source/JavaScriptCore/offlineasm/instructions.rb (modified) (1 diff)

trunk/Source/JavaScriptCore/offlineasm/instructions.rb

@@ -289 +289 @@
     "storedReversedAndDecrementAddress",
     "ldspr",
-    "stspr"
+    "stspr",
+    "setargs"
     ]