Changeset 159528 in webkit for trunk/Source/JavaScriptCore/runtime/JSFunction.cpp

Timestamp:

Nov 19, 2013, 3:48:23 PM (12 years ago)

Author:

[email protected]

Message:

Rename WatchpointSet::notifyWrite() should be renamed to WatchpointSet::fireAll()
​https://bugs.webkit.org/show_bug.cgi?id=124609

Source/JavaScriptCore:

Rubber stamped by Mark Lam.

notifyWrite() is a thing that SymbolTable does. WatchpointSet uses that terminology
because it was original designed to match exactly SymbolTable's semantics. But now
it's a confusing term.

• bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::fireAllSlow):

• bytecode/Watchpoint.h:

(JSC::WatchpointSet::fireAll):
(JSC::InlineWatchpointSet::fireAll):

• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

• runtime/JSFunction.cpp:

(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::haveABadTime):

• runtime/Structure.h:

(JSC::Structure::notifyTransitionFromThisStructure):

• runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::notifyWriteSlow):

Source/WebCore:

Rubber stamped by Mark Lam.

No new tests because no new behavior.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

• bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::create):

File:

• trunk/Source/JavaScriptCore/runtime/JSFunction.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/JSFunction.cpp

@@ -388 +388 @@
         thisObject->methodTable()->getOwnPropertySlot(thisObject, exec, propertyName, slot);
         thisObject->m_allocationProfile.clear();
-        thisObject->m_allocationProfileWatchpoint.notifyWrite();
+        thisObject->m_allocationProfileWatchpoint.fireAll();
         // Don't allow this to be cached, since a [[Put]] must clear m_allocationProfile.
         PutPropertySlot dontCache;
@@ -435 +435 @@
         thisObject->methodTable()->getOwnPropertySlot(thisObject, exec, propertyName, slot);
         thisObject->m_allocationProfile.clear();
-        thisObject->m_allocationProfileWatchpoint.notifyWrite();
+        thisObject->m_allocationProfileWatchpoint.fireAll();
         return Base::defineOwnProperty(object, exec, propertyName, descriptor, throwException);
     }